Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firewall: T3509: Add support for IPv6 reverse path filtering #2163

Merged
merged 3 commits into from
Aug 26, 2023

Conversation

sarthurdev
Copy link
Member

@sarthurdev sarthurdev commented Aug 23, 2023

Change Summary

Moves reverse path filtering to nftables with added support for IPv6.

  • Add set interfaces ethernet ethN ipv6 source-validation for per-interface setting.
  • set firewall global-options source-validation will set it across all interfaces, for both IPv4 and IPv6.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

firewall

Proposed changes

  • Moves reverse path filtering handling into nftables for both IPv4 and IPv6 support and removes sysfs references.
  • Adds smoketest to verify rules

How to test

Testing pending, marked ready once tested.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team, dmbaturin, zdc, jestabro, sever-sever and c-po and removed request for a team August 23, 2023 23:51
@sarthurdev sarthurdev changed the title firewall: T3509: Add support for IPv6 return path filtering firewall: T3509: Add support for IPv6 reverse path filtering Aug 23, 2023
@c-po
Copy link
Member

c-po commented Aug 24, 2023

Can we please make this "per interface" as we do with IPv4 and e.g. MSS settings?

set interfaces ethernet eth2 ipv6 source-validation

@sarthurdev sarthurdev force-pushed the firewall_rpfilter branch 2 times, most recently from 4c54459 to 1b580e5 Compare August 25, 2023 13:26
@sarthurdev sarthurdev marked this pull request as ready for review August 25, 2023 14:56
@vyosbot vyosbot requested a review from a team August 25, 2023 14:57
@c-po c-po added the current label Aug 25, 2023
@c-po c-po merged commit 75aa90c into vyos:current Aug 26, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants