wireguard: T5409: Added 'set interfaces wireguard wgX threaded' #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyosbot
requested review from
a team,
dmbaturin,
sarthurdev,
zdc,
jestabro,
sever-sever and
c-po
and removed request for
a team
|
Any reason to not enable this by default? |
Zero, if not negative, benefit for p2p interfaces. Also, bigger overall CPU usage (but distributed between cores). |
Added 'set interfaces wireguard wgX threaded' command. Process traffic from each peer in a dedicated thread.
aapostoliuk
force-pushed
the
T5409-sagitta
branch
from
3500f55
to
0d54be7
Compare
sever-sever
approved these changes
Aug 7, 2023
c-po
requested changes
Aug 7, 2023
dmbaturin
approved these changes
Aug 7, 2023
If it will be a config option, can we then try to streamline it, as it‘s kind of an offload option? As we use offloading for other interface types ethernet, openvpn, too?
|
|
As discussed in todays maintainer meeting we agreed on: And also implement this for the WIFI subsystem |
Using threaded as CLI node is a very deep term used by kernel threads. To make this more understandable to users, rename the node to per-client-thread. It's also not necessary to test if any one peer is configured and probing if the option is set. There is a base test which requires at least one peer to be configured.
Provides a per-device control to enable/disable the threaded mode for all the napi instances of the given network device, without the need for a device up/down.
c-po
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added 'set interfaces wireguard wgX threaded' command.
Process traffic from each peer in a dedicated thread.
Types of changes
Related Task(s)
Component(s) name
wireguard
Proposed changes
Added 'set interfaces wireguard wgX threaded' command.
Process traffic from each peer in a dedicated thread.
This command is allowed only if one enabled peer exists
How to test
Checklist: