Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5374: Add system option time-format 12 or 24 hours #2124

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

sever-sever
Copy link
Member

@sever-sever sever-sever commented Aug 1, 2023

Change Summary

Ability to set locale time format 12|24-hour

set system option time-format 12-hour|24-hour

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

time

Proposed changes

How to test

vyos@r14:~$ date
Tue Aug  1 12:33:45 PM EEST 2023
vyos@r14:~$ 

Set 24-hour format and re-login to the system

vyos@r14# set system option time-format 24-hour 
[edit]
vyos@r14# commit
[edit]
vyos@r14# exit
Warning: configuration changes have not been saved.
exit
vyos@r14:~$ logout
Connection to 192.168.122.14 closed.
sever@sever:~$ sr14
Warning: Permanently added '192.168.122.14' (ED25519) to the list of known hosts.
Welcome to VyOS!

vyos@r14:~$ 
vyos@r14:~$ date
Tue  1 Aug 12:34:09 EEST 2023
vyos@r14:~$ 

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Ability to set locate time format 12|24-hour

set system option time-format 12-hour|24-hour

$ date
Tue Aug  1 12:33:45 PM EEST 2023

$ date
Tue  1 Aug 12:34:09 EEST 2023
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and c-po and removed request for a team August 1, 2023 09:41
@c-po c-po merged commit 1429fe3 into vyos:current Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants