haproxy: implement sd_notify for mworker mode #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlallemand
force-pushed
the
haproxy-sd_notify
branch
from
0e77fcd
to
fd4dab6
Compare
With the previous implementation of the haproxy mworker mode, VTest was waiting for the pidfile to be created to start the tests. From time to time it was causing issues, because the pidfile could be ready before haproxy is completely ready. With haproxy 3.1 and the new master-worker model this is even worse, because the pidfile is created before parsing the configuration, so haproxy is never ready. This patch implements the -Ws mode of haproxy, which was initially made to support the sd_notify API of systemd. This mode sends READY=1 message over a SOCK_DGRAM unix socket once haproxy is completely ready. In order to receive the message, VTest binds on a UNIX sockets and stores the path of this socket in the NOTIFY_SOCKET environment variable. Once the message is received, VTest will start the tests.
wlallemand
force-pushed
the
haproxy-sd_notify
branch
from
fd4dab6
to
f374b64
Compare
|
mergeable now, lacked a minor fix |
haproxy-mirror
pushed a commit
to haproxy/haproxy
that referenced
this pull request
Nov 20, 2024
Build VTest temporarily from the sd-notify PR until the vtest/VTest#41 is merged. This PR allows starting with -Ws in order to have more reliables tests in master-worker mode.
haproxy-mirror
pushed a commit
to haproxy/haproxy
that referenced
this pull request
Nov 20, 2024
Build VTest temporarily from the sd-notify PR until the vtest/VTest#41 is merged. This PR allows starting with -Ws in order to have more reliables tests in master-worker mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous implementation of the haproxy mworker mode, VTest was waiting for the pidfile to be created to start the tests. From time to time it was causing issues, because the pidfile could be ready before haproxy is completely ready. With haproxy 3.1 and the new master-worker model this is even worse, because the pidfile is created before parsing the configuration, so haproxy is never ready.
This patch implements the -Ws mode of haproxy, which was initially made to support the sd_notify API of systemd. This mode sends READY=1 message over a SOCK_DGRAM unix socket once haproxy is completely ready. In order to receive the message, VTest binds on a UNIX sockets and stores the path of this socket in the NOTIFY_SOCKET environment variable. Once the message is received, VTest will start the tests.