Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default doc type to delete #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AdamGold
Copy link

add doc_type="_doc" to delete method

add `doc_type="_doc"` to delete method
@AdamGold AdamGold changed the title Update fake_elasticsearch.py add default doc type to delete Jan 28, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.83% when pulling 4561dc9 on AdamGold:patch-2 into 4df0f86 on vrcmarcos:master.

@vrcmarcos
Copy link
Owner

Humm change the parameters' order may lead to broken builds by anyone using this method.

Do you think that this change still worth? If yes, wdyt of create a new method that already uses the default value?

@AdamGold
Copy link
Author

Wondering maybe creating a backwards_compatible decorator is better than creating a new method.

@vrcmarcos
Copy link
Owner

Humm, good point. Do you still think that we should merge it even knowing that this is a breaking change?

Maybe we can do it but add a warning on the Readme and bumping the Major Version. Wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants