Improve test coverage #1028
Merged
Improve test coverage #1028
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve test coverage in main class spec
wyardley
force-pushed
the
wyardley/test_coverage
branch
from
47498e3
to
f43d0ef
Compare
bastelfreak
approved these changes
Nov 16, 2024
|
I'm trying to add some additional coverage for one other thing, but I'm seeing some quirks with it, so I'll PR separately. |
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
Nov 17, 2024
- Remove support for CentOS / RHEL 7 (breaking change) - Remove workarounds specific to EPEL and require_epel parameter (breaking change) - Add support for CentOS / RHEL 9 in metadata - Where repos_ensure is not set, install centos-release-rabbitmq-38 to support installing RabbitMQ from semi-official source - Add in some additional tests for coverage (followup to voxpupuli#1028) that were hard to test without a supported RedHat family OS in metadata Fixes voxpupuli#816 Signed-off-by: William Yardley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Improve test coverage in main class spec
Resolves some basic coverage issues reported at the end of unit test runs.
Before:
After:
Could potentially be some branches that could be covered better, but overall, this seems like a Good Thing (TM).
This Pull Request (PR) fixes the following issues