Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client_renegotiation ssl option, use more ssl options in management plugin #1024

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Nov 14, 2024

Rework of #906, credit to @Infraded

  1. Adds the option for client_renegotiation to rabbitmq config
  2. Copies multiple options from rabbitmq config to management plugin config similar to existing ssl settings
    • client_renegotiation
    • secure_renegotiate
    • reuse_sessions
    • honor_cipher_order
  3. Wraps client_renegotiation and secure_renegotiate in a conditional to not include them when enabling TLSv1.3 as they are incompatible
  4. Updates/add tests for client_renegotation setting and TLSv1.3 conditional

@Infraded I reworked your PR, since the conflicts still hadn't been resolved. This necessitated rewriting the template changes in epp.

Probably should be squash merged

This Pull Request (PR) fixes the following issues

Closes #906

@wyardley wyardley added the enhancement New feature or request label Nov 14, 2024
@wyardley wyardley force-pushed the Infraded-master branch 2 times, most recently from addfa75 to 2ec5542 Compare November 15, 2024 07:01
data/common.yaml Outdated Show resolved Hide resolved
@wyardley wyardley merged commit ec9a24b into master Nov 16, 2024
11 checks passed
@wyardley wyardley deleted the Infraded-master branch November 16, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants