switch to stdlib namespaced functions, require stdlib 9.x

[tuxmea]

No description provided.

[evgeni]

(the tests install puppetlabs-stdlib (v8.6.0) which explains why it was not caught during bumping)

[evgeni]

@bastelfreak would this be considered a breaking change?

technically it's fixing a bug introduced by #691 which allowed stdlib 9.x without using the new namespaced name (insert raising fist emoji), so I'd lean to "no", but requirement bumps always give me headaches.

Edit:

OTOH, looking at CI logs, 9.3.0 has a non-namespaced version, and things did work with it:

2023-09-21T07:55:17.3931405Z �[00;00m�[00;33m  Warning: This function is deprecated, please use stdlib::ensure_packages instead. at ["/etc/puppetlabs/code/environments/production/modules/php/manifests/pear.pp", 50]:["/tmp/apply_manifest_075508438.pp.8vjBav", 1]
2023-09-21T07:55:17.3933171Z      (location: /etc/puppetlabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:35:in `deprecation')

So it was not a bug as such?

[evgeni]

@tuxmea I guess the following places should also be updated?

puppet-php/manifests/phpunit.pp

Line 26 in d5c3d66

ensure_packages(['wget'])

puppet-php/manifests/pear.pp

Line 50 in d5c3d66

ensure_packages(["${php::package_prefix}xml"], { ensure => present, require => $require, })

[tuxmea]

@tuxmea I guess the following places should also be updated?

puppet-php/manifests/phpunit.pp

Line 26 in d5c3d66

ensure_packages(['wget'])

puppet-php/manifests/pear.pp

Line 50 in d5c3d66

ensure_packages(["${php::package_prefix}xml"], { ensure => present, require => $require, })

Done

[evgeni]

I'm fine with the change, but unsure how to label that in terms of bug/enhancement/breaking.

I thought stdlib 9.x was breaking the old, non-namespaced calling of ensure_packages (which would make this a bugfix), but it seems there is a shim and it works fine (emitting a deprecation warning), making this either an enhancement or a breaking change (depending on "is bumping a req a breaking change"). I lean towards enhancement.

[tuxmea]

As ensure_packages is available (and shows a deprecation) I would consider this to not be a breaking change. But I am open to other opinions. @bastelfreak what do you prefer?

[smortex]

Changing the lower version is a breaking change (e.g. users of version 7.0.0 will have unmet dependencies when updating, and ignoring it would break their catalog as the namespaced function is not available).

[smortex]

LGTM!