Create olcDbDirectory before its database and the start of slapd

manifests/server.pp

@@ -47,6 +47,6 @@
   Class['openldap::server::install']
   -> Class['openldap::server::config']
   ~> Class['openldap::server::service']
-  -> Class['openldap::server::slapdconf']
+  Class['openldap::server::slapdconf']
   -> Class['openldap::server']
 }

manifests/server/database.pp

@@ -52,18 +52,18 @@
   }
 
   Class['openldap::server::service']
-  -> Openldap::Server::Database[$title]
+  -> Openldap_database[$title]
   -> Class['openldap::server']
   if $title != 'dc=my-domain,dc=com' and fact('os.family') == 'RedHat' {
-    Openldap::Server::Database['dc=my-domain,dc=com'] -> Openldap::Server::Database[$title]
+    Openldap_database['dc=my-domain,dc=com'] -> Openldap_database[$title]
   }
 
   if $ensure == present and $backend != 'monitor' and $backend != 'config' and $backend != 'relay' and $backend != 'ldap' {
     file { $manage_directory:
       ensure => directory,
       owner  => $openldap::server::owner,
       group  => $openldap::server::group,
-      before => Openldap_database[$title],
+      before => [Class['openldap::server::service'], Openldap_database[$title]],
     }
   }
 

spec/classes/openldap_server_spec.rb

@@ -23,11 +23,6 @@
               that_notifies('Class[openldap::server::service]')
           }
 
-          it {
-            is_expected.to contain_class('openldap::server::service').
-              that_comes_before('Class[openldap::server::slapdconf]')
-          }
-
           it {
             is_expected.to contain_class('openldap::server::slapdconf').
               that_comes_before('Class[openldap::server]')

spec/defines/openldap_server_database_spec.rb

@@ -21,6 +21,24 @@
             it {
               is_expected.to contain_openldap__server__database('dc=foo').with(directory: '/foo/bar')
             }
+
+            it {
+              # The slapd service must be started before we can make a database:
+              is_expected.to contain_class('openldap::server::service').
+                that_comes_before('Openldap_database[dc=foo]')
+            }
+
+            it {
+              # The containing directory for a database must exist before the database that it will contain:
+              is_expected.to contain_file('/foo/bar').
+                that_comes_before('Openldap_database[dc=foo]')
+            }
+
+            it {
+              # ... and "the specified olcDbDirectory must exist prior to starting slapd(8)":
+              is_expected.to contain_file('/foo/bar').
+                that_comes_before('Class[openldap::server::service]')
+            }
           end
 
           context 'with all parameters set' do