Adding support for the gitlab_sshd configuration hash #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
reviewed
Oct 7, 2023
There was a problem hiding this comment.
LGTM. What do you think about updating the README since #417 says it is confusing? At least we can remove the bit that says that the module cannot manage SSH, but if you have experience with this you may want to provide some guidance?
|
I'll try and reword that section of the README |
|
@smortex How is the status on this? Can it be merged? |
smortex
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adding support for the gitlab_sshd configuration
This Pull Request (PR) fixes the following issues
Fixes #417