Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for custom scripts in /docker-entrypoint.d and run custom scripts in order #133

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

zipkid
Copy link
Member

@zipkid zipkid commented Oct 10, 2024

Run custom scripts in filename order
Add support for custom scripts in /docker-entrypoint.d for different stages of the entrypoint

Run custom scripts in filename order
Add support for custom scripts in /docker-entrypoint.d for different stages of the entrypoint
@zipkid zipkid requested a review from a team as a code owner October 10, 2024 08:14
@rwaffen
Copy link
Member

rwaffen commented Oct 11, 2024

oh, that's a lot more executions. may you please update all the nested echos of "Running xyz" to make more clear in which step we are?

@zipkid
Copy link
Member Author

zipkid commented Oct 11, 2024

oh, that's a lot more executions. may you please update all the nested echos of "Running xyz" to make more clear in which step we are?

Although, the echo shows the full path of the script. So that makes clear what step it is from.

Right?

@rwaffen
Copy link
Member

rwaffen commented Oct 11, 2024

does the echo show full path? then its okay. thought it only shows Running name.sh ?

@zipkid
Copy link
Member Author

zipkid commented Oct 11, 2024

does the echo show full path? then its okay. thought it only shows Running name.sh ?

This is the output (in ECS)

October 11, 2024 at 11:47 (UTC+2:00) Running /docker-custom-entrypoint.d/post-startup/20_puppetserver_gem_install.sh
October 11, 2024 at 11:45 (UTC+2:00) Running /docker-custom-entrypoint.d/post-startup/01_wait_for_puppetcert_and_server.sh
October 11, 2024 at 11:45 (UTC+2:00) Running /docker-custom-entrypoint.d/60_puppet_autosign.sh
October 11, 2024 at 11:45 (UTC+2:00) Running /docker-custom-entrypoint.d/50_r10k_config.sh

Also fix linter errors about bold setting
@rwaffen rwaffen self-assigned this Oct 11, 2024
@rwaffen rwaffen changed the title Update entrypoint feat: add support for custom scripts in /docker-entrypoint.d and run custom scripts in order Oct 12, 2024
@rwaffen rwaffen merged commit fd50897 into voxpupuli:main Oct 12, 2024
11 checks passed
@zipkid zipkid deleted the feature/entrypoint branch October 14, 2024 04:45
@rwaffen rwaffen added the enhancement New feature or request label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants