Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update health check to better find certs for curl #131

Merged
merged 1 commit into from
Oct 9, 2024
Merged

feat: update health check to better find certs for curl #131

merged 1 commit into from
Oct 9, 2024

Conversation

rwaffen
Copy link
Member

@rwaffen rwaffen commented Oct 9, 2024 •
edited
Loading

Fixes: #130

@rwaffen rwaffen added the enhancement New feature or request label Oct 9, 2024
@rwaffen rwaffen requested a review from a team as a code owner October 9, 2024 08:07
@rwaffen rwaffen linked an issue Oct 9, 2024 that may be closed by this pull request
Container health-check fails after creating a certificate #130
Closed
@rwaffen rwaffen changed the title fix: update health check to better find certs fur curl fix: update health check to better find certs for curl Oct 9, 2024
@rwaffen rwaffen changed the title fix: update health check to better find certs for curl feat: update health check to better find certs for curl Oct 9, 2024
@rwaffen rwaffen force-pushed the 130-container-health-check-fails-after-creating-a-certificate branch from aa13fbd to 0594e39 Compare October 9, 2024 08:08
@rwaffen
Copy link
Member Author

rwaffen commented Oct 9, 2024 •
edited
Loading

the healthcheck may fail on start of a new instance because maybe cert is not ready yet, but it should recover after some time after startup 🤔 ... testing is ongoing.

@rwaffen
Copy link
Member Author

rwaffen commented Oct 9, 2024

tests look good... i think this works as intended.

@rwaffen rwaffen merged commit ddf7a2b into main Oct 9, 2024
11 checks passed
@rwaffen rwaffen deleted the 130-container-health-check-fails-after-creating-a-certificate branch October 9, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Crafty Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Container health-check fails after creating a certificate
2 participants
@rwaffen @bastelfreak