Don't let the entry scripts fail if there is no cert (dir) #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a fail will fail the entire instance. When the certs (dir) is missing, it gets recreated at puppetserver startup anyway.
|
LGTM. did you run some local tests with it? we dont have ci tests yet, that validate that the container is still start-able 😅 |
I have tested this with and without the ssl/ dir. |
|
so i should wait until you add that. ok. |
Even when when CA_ENABLED is true. The instance of the puppetserver also needs the DNS_ALT_NAMES set. This also requires CA_ALLOW_SUBJECT_ALT_NAMES to be set to true.
rwaffen
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a fail will fail the entire instance.
When the certs (dir) is missing, it gets recreated at puppetserver startup anyway.