Skip to content

Commit

Permalink
Merge pull request #1875 from bastelfreak/validate
Browse files Browse the repository at this point in the history
drop validate_setup method
  • Loading branch information
ekohl authored May 10, 2024
2 parents a977012 + d293cbc commit d3b882b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 13 deletions.
6 changes: 3 additions & 3 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2024-05-10 14:44:46 UTC using RuboCop version 1.62.1.
# on 2024-05-10 15:53:37 UTC using RuboCop version 1.62.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -155,7 +155,7 @@ RSpec/Eq:
Exclude:
- 'spec/beaker/logger_spec.rb'

# Offense count: 232
# Offense count: 231
# Configuration parameters: CountAsOne.
RSpec/ExampleLength:
Max: 44
Expand Down Expand Up @@ -219,7 +219,7 @@ RSpec/MultipleMemoizedHelpers:
RSpec/NamedSubject:
Enabled: false

# Offense count: 42
# Offense count: 41
# Configuration parameters: AllowedPatterns.
# AllowedPatterns: ^expect_, ^assert_
RSpec/NoExpectationExample:
Expand Down
9 changes: 0 additions & 9 deletions lib/beaker/host/unix.rb
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,6 @@ def skip_set_env?
end
end

# Validates that the host was setup correctly
#
# @return nil
# @raise [ArgumentError] If the host is setup incorrectly,
# this will be raised with the appropriate message
def validate_setup
nil
end

def initialize name, host_hash, options
super

Expand Down
1 change: 0 additions & 1 deletion lib/beaker/network_manager.rb
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ def provision
@machines[hypervisor] = [] unless @machines[hypervisor]
hostless_options[:timesync] = host_hash[:timesync] if host_hash[:timesync] != nil
host_itself = Beaker::Host.create(name, host_hash, hostless_options)
host_itself.validate_setup
@machines[hypervisor] << host_itself
end

Expand Down

0 comments on commit d3b882b

Please sign in to comment.