Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the forms file, add placeholder support #1330

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on May 30, 2014

  1. Bug fix for checkboxes in form dialogues

    This commit fixes a bug in form dialogues where the checkbox property is not actually toggled back a second time when using the label text. The issue is caused by the use of the `checked` attribute (`.attr('checked'`) because changing this attribute is not guarenteed to update the element `checked` property. Attached is an image proving how this can arise in an updated version of Chrome. See how the attribute is present but the property does not match. This was after clicking the `span` element a second time.
    
    Using the `.prop` method of the jQuery we use fixes this issue totally. It is suggested other usage of `attr` on checkboxes is revised.
    
    Proof: http://i.imgur.com/KGM9LUd.png
    deed02392 committed May 30, 2014
    Configuration menu
    Copy the full SHA
    3dd7740 View commit details
    Browse the repository at this point in the history
  2. Update jquery.jtable.js

    Remove extra line space
    deed02392 committed May 30, 2014
    Configuration menu
    Copy the full SHA
    2d0b73f View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1 from deed02392/patch-1

    Checkbox bug fix
    deed02392 committed May 30, 2014
    Configuration menu
    Copy the full SHA
    3df32f3 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2014

  1. Update the forms extension file

    Now the new complete file can be built
    deed02392 committed May 31, 2014
    Configuration menu
    Copy the full SHA
    4ff79b6 View commit details
    Browse the repository at this point in the history
  2. Implement placeholder field property

    TODO: Minify and update documentation.
    
    Added field placeholder property,
    
    eg
    
    ```javascript
    username: {
    title: 'Username',
    width: '20%',
    create: true,
    placeholder: "Optional",
    key: true,
    sorting: false
    },
    
    ```
    Tested safe back to IE6 (placeholder attribute not supported but is
    simply ignored). Works on IE10+. Also tested on Chrome and several
    mobile browsers.
    deed02392 committed May 31, 2014
    Configuration menu
    Copy the full SHA
    fee6882 View commit details
    Browse the repository at this point in the history