DEP: drop dependency on rich (replaced by atomic dependencies termcolor + tqdm)
#375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
changed the title
rich (replaced by atomic dependencies termcolor + tqdm)
|
Actually I moved the bugfix part to #376 and it is now clear that the current behavior of ignoring |
neutrinoceros
force-pushed
the
dep/drop_rich
branch
4 times, most recently
from
e793c41
to
7e097cf
Compare
neutrinoceros
force-pushed
the
dep/drop_rich
branch
from
7e097cf
to
4bc10dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards minimizing the total number of (direct+indirect) dependencies.
Switching to tqdm for progress bars also allows to fix a known bug where
-progressBarhas no effect with-ncpu 1A minor setback I need to resolve is that tqdm doesn't interact with pytest as nicely as rich.progress, meaning that in
test_pbar, we cannot accurately check wether the progress bar was cleaned up afterward, causing the test to fail, even though manual testing shows that the behavior matches what's intended.