chore: updated debian 12 and ubuntu 22.04 links #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthirtyam
requested changes
Nov 29, 2024
project.json
Outdated
| @@ -51,9 +51,9 @@ | |||
| "architectures": [ | |||
| { | |||
| "architecture": "amd64", | |||
| "download_link": "https://mirror.cogentco.com/debian-cd/12.7.0/amd64/iso-cd/debian-12.7.0-amd64-netinst.iso", | |||
| "download_link": "https://mirror.cogentco.com/debian-cd/12.8.0/amd64/iso-cd/debian-12.7.0-amd64-netinst.iso", | |||
There was a problem hiding this comment.
Doesn't seem correct.
|
Commits require the sign off. |
Included the default download path in the .gitignore
|
I double checked and bumped all the URLs for:
|
|
Your commit still requires a sign-off. |
tenthirtyam
requested changes
Dec 1, 2024
There was a problem hiding this comment.
Each commit requires a sign-off.
For example, squash or amend each and included your version of the below based on your GitHub display name and the associated email address in your GitHub account.
Signed-off-by: Ryan Johnson <[email protected]>
| @@ -52,6 +52,10 @@ artifacts/**/*.nvram | |||
| artifacts/**/*.ovf | |||
| artifacts/**/*.vmdk | |||
|
|
|||
| ## Ignore ISO path | |||
There was a problem hiding this comment.
Suggested change
| ## Ignore ISO path | |
| ## Ignore ISO Path |
| @@ -52,6 +52,10 @@ artifacts/**/*.nvram | |||
| artifacts/**/*.ovf | |||
| artifacts/**/*.vmdk | |||
|
|
|||
| ## Ignore ISO path | |||
| iso/ | |||
|
|
|||
| "checksum_algorithm": "sha256", | ||
| "checksum": "https://dl.rockylinux.org/vault/rocky/9.4/isos/x86_64/CHECKSUM" | ||
| "checksum": "https://dl.rockylinux.org/vault/rocky/9.5/isos/x86_64/CHECKSUM" |
There was a problem hiding this comment.
Not mentioned in the summary.
| "checksum_algorithm": "sha256", | ||
| "checksum": "https://repo.almalinux.org/almalinux/9.4/isos/x86_64/CHECKSUM" | ||
| "checksum": "https://repo.almalinux.org/almalinux/9.5/isos/x86_64/CHECKSUM" |
There was a problem hiding this comment.
Not mentioned in the summary.
| @@ -473,14 +473,14 @@ | |||
| "versions": { | |||
| "40": [ | |||
| { | |||
| "version": "40", | |||
| "version": "41", | |||
There was a problem hiding this comment.
This would need to be updated in the docs and README.md.
tenthirtyam
requested changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Pull Request
Updated the download links for Debian 12 and Ubuntu 22.04
Type of Pull Request
type/bugtype/featureortype/enhancementtype/docstype/refactortype/chorePlease describe:
Related to Existing Issues
Issue Number: N/A
Test and Documentation Coverage
Breaking Changes?