Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ubuntu): restablish empty default grub cmdline after cloud-init install #982

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sticky-note
Copy link

@sticky-note sticky-note commented Nov 12, 2024

Summary of Pull Request

I ran into #981 today, it seems to come from GRUB_CMDLINE_LINUX_DEFAULT being set on packer template provisioning via cloud-init installer.
It is set by packer boot_command on kernel cmdline arguments and tell cloud-init to use a specific DataSource (nocloud-net or nocloud) and the installer persists these arguments on grub configuration in /etc/default/grub.
It it the reason why cloud-init does not read VMware DataSource.

I ended up with this Pull Request to restablish an empty GRUB_CMDLINE_LINUX_DEFAULT as late_command

It works on my side

Tested on Ubuntu 22.04 LTS

Hope it'll help someone.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #981

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam
Copy link
Collaborator

@sticky-note - please amend your commit with the required sign-off. Once updated, we'll be able to review and proceed.

Thanks!

Ryan Johnson
Distinguished Engineer, VMware by Broadcom

@tenthirtyam tenthirtyam modified the milestones: Backlog, v0.22.0 Nov 21, 2024
@tenthirtyam
Copy link
Collaborator

@sticky-note - if you are uncomfortable adding the sign-off, please let me know and I'll add the fix seperately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to assign static IP to Ubuntu 22.04 image result with cloud-init
2 participants