Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Update to outlines > 0.1.4 #10576

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

russellb
Copy link
Collaborator

@russellb russellb commented Nov 22, 2024

This PR shows the progression of upgrading to the latest release of outlines.
It updates to 0.1.4, fixes a problem when using that release (and the next
one), and prepares requirements-common.txt for when that next release comes
out.

65ab031 [Core] Update to outlines 0.1.4
9e62cfe [Core] Stop using outlines.caching.cache
b8c2895 [Build/CI] Require outlines > 0.1.4

commit 65ab031
Author: Russell Bryant [email protected]
Date: Thu Nov 21 21:25:22 2024 +0000

[Core] Update to outlines 0.1.4

Signed-off-by: Russell Bryant <[email protected]>

commit 9e62cfe
Author: Russell Bryant [email protected]
Date: Thu Nov 21 23:03:49 2024 +0000

[Core] Stop using outlines.caching.cache

This is broken, and the fix in outlines itself was to just stop using
it, so we should do the same.

references:

- https://github.com/dottxt-ai/outlines/issues/1274
- https://github.com/dottxt-ai/outlines/pull/1278

Signed-off-by: Russell Bryant <[email protected]>

commit b8c2895
Author: Russell Bryant [email protected]
Date: Fri Nov 22 15:33:11 2024 +0000

[Build/CI] Require outlines > 0.1.4

Since 0.1.4 is known to be broken, set our requirement to be above it.
0.1.5 has not yet been released, so this will have to be on hold until
it's out.

Signed-off-by: Russell Bryant <[email protected]>

Signed-off-by: Russell Bryant <[email protected]>
This is broken, and the fix in outlines itself was to just stop using
it, so we should do the same.

references:

- dottxt-ai/outlines#1274
- dottxt-ai/outlines#1278

Signed-off-by: Russell Bryant <[email protected]>
Since 0.1.4 is known to be broken, set our requirement to be above it.
0.1.5 has not yet been released, so this will have to be on hold until
it's out.

Signed-off-by: Russell Bryant <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@russellb
Copy link
Collaborator Author

0.1.5 has been released, so this is ready to test

@russellb russellb marked this pull request as ready for review November 22, 2024 16:27
@russellb russellb marked this pull request as draft November 22, 2024 16:59
@russellb
Copy link
Collaborator Author

converted back to a draft because I don't have 0.1.5 working locally, yet ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant