Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Refactor model executable interface for multimodal models #10570

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Nov 22, 2024

This PR refactors the interface of all multimodal language models for V1 VLM re-arch and torch.compile support. In particular, all multimodal model implementations on vLLM will need to meet the following requirements:

  • get_multimodal_embeddings(**kwargs) implemented in XYZModel or XYZForConditionalGeneration
  • get_input_embeddings(input_ids, multimodal_embeddings) implemented in XYZModel or XYZForConditionalGeneration to output input embeddings to be passed to the language backbone.
  • Backward compatibility added for V0 in XYZModel or XYZForConditionalGeneration until V0 is fully deprecated.

List of LMMs to be worked on

  • BLIP2
  • Chameleon
  • GLM
  • Fuyu
  • Intern-VL
  • Llava-next
  • Llava-next-video
  • Llava-one-vision
  • Molmo
  • Paligemma
  • Pixtral
  • Qwen2VL
  • Ultravox

This PR is a prerequisite of applying #9871 to all multimodal models on vLLM.

Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
@DarkLight1337 DarkLight1337 self-assigned this Nov 23, 2024
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants