Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up unneceesary bytes from x.encoding.asn module #22932

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

blackshirt
Copy link
Contributor

@blackshirt blackshirt commented Nov 21, 2024

This PR contains some small cleans up of unnecessary bytes from x.encoding.asn1 module, includes :

  • Cleaning up some examples to align with recent fixed issues by greats work by @felipensp , 22901, 22855, 22721
  • Removed extra test (this is not really needed), it test is for x509 certificates, where i have it on other branch.
  • Clearing some bits of unnecessary pieces of code.

Thanks,

Huly®: V_0.6-21374

@spytheman
Copy link
Member

There is no need to delete the _test.v files, unless you do want that; they are skipped, when others do import x.encoding.asn1, and will not affect the resource usage of compilations.

@spytheman spytheman merged commit 58fc4de into vlang:master Nov 21, 2024
62 checks passed
@blackshirt
Copy link
Contributor Author

There is no need to delete the _test.v files, unless you do want that; they are skipped, when others do import x.encoding.asn1, and will not affect the resource usage of compilations.

Its actually for x509 certificate parser i'm working on, so its why i'm make pr to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants