term: improve performance by caching redundant can_show_color calls #22893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the term module for CLI projects, functions like
colorize
and other functions that check first for the ability to display colors can be called quite a lot. Currently the value ofcan_show_color_on_stdout()->supports_escape_sequences()
is re-processed on every call of these functions.v/vlib/term/term.v
Lines 184 to 202 in 5bba92a
The changes add a cache for the can_show_color status which results in a speedup of 100%+.
Huly®: V_0.6-21336