Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: fix return type checker when returning struct which implements IError on non-result fn #22660

Merged
merged 4 commits into from
Oct 27, 2024
Merged

checker: fix return type checker when returning struct which implements IError on non-result fn #22660

merged 4 commits into from
Oct 27, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Oct 26, 2024 •
edited by huly-for-github bot
Loading

@felipensp felipensp marked this pull request as ready for review October 26, 2024 14:28
spytheman
spytheman approved these changes Oct 27, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 🥳 .

And a very elegant fix too.

@spytheman spytheman merged commit 1ced1e9 into vlang:master Oct 27, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Delta456 Delta456 Delta456 approved these changes

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C error when returning Error{} as int C error when returning Error{} as result
3 participants
@felipensp @spytheman @Delta456