Start autoplay when video is in view #2839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliawegmayr
force-pushed
the
start-autoplay-when-video-is-in-view
branch
from
58f2db7
to
9688201
Compare
juliawegmayr
force-pushed
the
start-autoplay-when-video-is-in-view
branch
from
9688201
to
13a48c7
Compare
johnnyomair
reviewed
Nov 28, 2024
There was a problem hiding this comment.
These functions should be in the respective blocks. There's no need for a separate file IMO.
| @@ -0,0 +1,20 @@ | |||
| import { RefObject, useEffect, useState } from "react"; | |||
|
|
|||
| export const useIsElementVisible = (ref: RefObject<HTMLDivElement>) => { | |||
There was a problem hiding this comment.
Naming: useIsElementInViewport would probably be better. An element can still be hidden using display: none.
BTW, nice implementation using IntersectionObserver 👏🏼
johnnyomair
force-pushed
the
start-autoplay-when-video-is-in-view
branch
from
a48e93d
to
108a218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Videos that are set to autoplay should only start if the user scrolls to the Video. If he scrolls away, the video should pause. Implementation for: DamVideoBlock, YoutubeVideoBlock and VimeoVideoBlock.
Screenshots/screencasts
DamVideoBlock:
Screen.Recording.2024-11-27.at.13.32.10.mov
YoutubeVideoBlock:
Screen.Recording.2024-11-27.at.13.34.19.mov
VimeoVideoBlock:
Screen.Recording.2024-11-27.at.13.35.36.mov
Changeset
Related tasks and documents
(https://vivid-planet.atlassian.net/browse/COM-1313)