Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate back to blocks-overview when closing the TableBlock #2805

Open
wants to merge 1 commit into
base: feature/table-block
Choose a base branch
from

Conversation

jamesricky
Copy link
Contributor

@jamesricky jamesricky commented Nov 22, 2024

Related tasks and documents

https://vivid-planet.atlassian.net/browse/COM-1015

Open TODOs/questions

@jamesricky jamesricky self-assigned this Nov 22, 2024
@jamesricky jamesricky mentioned this pull request Nov 22, 2024
1 task
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I was to use the table block inside a composite block, this would navigate to the parent of the composite block.

@jamesricky
Copy link
Contributor Author

If I was to use the table block inside a composite block, this would navigate to the parent of the composite block.

Is there a way to check, how this block is being used? 🤔

If it's used as a standalone block it makes sense to open the dialog automatically and navigate back when closed.
But when it is used inside a composite block, it might make sense to add a open/edit button and remove the back-navigation, as you mentioned.

Base automatically changed from table-block-base-setup to feature/table-block November 27, 2024 11:44
@johnnyomair
Copy link
Collaborator

Is there a way to check, how this block is being used?

I'm not sure, maybe we could check the current location. If it's used inside a sub route, then it's probably a composite block. We can pair on this one.

@jamesricky jamesricky mentioned this pull request Nov 27, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants