Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NestJS peer dependencies to @comet/cms-api peer dependencies #2796

Draft
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

johnnyomair
Copy link
Collaborator

Description

While upgrading NestJS I've noticed that they have class-transformer, class-validator, reflect-metadata, and rxjs as peer dependencies. I think it's a good idea that we have them as peer dependencies as well.

Open TODOs/questions

  • Changeset
  • Test if there are two reflect-metadata instances after upgrading MikroORM

@johnnyomair johnnyomair self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant