Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvOS: NetworkStream UI: Add sorting button new to old #451

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

embeddedc
Copy link

@embeddedc embeddedc commented Aug 16, 2022

Checklist

  • I've run bundle exec fastlane test from the fastlane directory to see all new and existing tests pass
  • I've followed the vlc-ios code style
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Description

It is annoying that new stream URLs are added at the bottom to the list, so you have to scroll down to resume a recent stream.

Can we add a setting to change this behavior? Alternatively I added a "reverse sorting" button with this PR.

@embeddedc embeddedc changed the title Add sorting button tvOS: NetworkStream UI: Add sorting button new to old Aug 18, 2022
@embeddedc embeddedc marked this pull request as ready for review August 18, 2022 09:38
@fkuehne
Copy link
Contributor

fkuehne commented Aug 19, 2022

Why not always show the last stream first like in the iOS interface?

@embeddedc
Copy link
Author

embeddedc commented Sep 2, 2022

Why not always show the last stream first like in the iOS interface?

I like my button. 😀

Does this really work differently on iOS? The logic seems to be the same?

Also I don't understand

[_recentURLs removeLastObject];

With the current order, this removes the latest not the oldest entry?

Would you prefer a PR for embeddedc@6aba00b?

That should reverse the sorting and fix above misbehavior..

@fkuehne
Copy link
Contributor

fkuehne commented Sep 6, 2022

I prefer to not have a button at all and always have the latest stream at the top and the oldest at the bottom. This is the behaviour on iOS and that on tvOS, it is reverse is simply a bug.

A MR for the referenced commit would be appreciated on our own gitlab here: https://code.videolan.org/videolan/vlc-ios

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants