-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tvOS: NetworkStream UI: Add sorting button new to old #451
base: master
Are you sure you want to change the base?
Conversation
c474576
to
cb358bf
Compare
cb358bf
to
e88af7b
Compare
9802951
to
ff4151a
Compare
Why not always show the last stream first like in the iOS interface? |
I like my button. 😀 Does this really work differently on iOS? The logic seems to be the same? Also I don't understand
With the current order, this removes the latest not the oldest entry? Would you prefer a PR for embeddedc@6aba00b? That should reverse the sorting and fix above misbehavior.. |
I prefer to not have a button at all and always have the latest stream at the top and the oldest at the bottom. This is the behaviour on iOS and that on tvOS, it is reverse is simply a bug. A MR for the referenced commit would be appreciated on our own gitlab here: https://code.videolan.org/videolan/vlc-ios Thank you! |
Checklist
bundle exec fastlane test
from thefastlane
directory to see all new and existing tests passDescription
It is annoying that new stream URLs are added at the bottom to the list, so you have to scroll down to resume a recent stream.
Can we add a setting to change this behavior? Alternatively I added a "reverse sorting" button with this PR.