RSDK-9339: Update python doc strings for tabular_data_by_sql/mql #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckras
requested review from
stuqdog,
lia-viam,
sguequierre and
njooma
and removed request for
stuqdog and
njooma
stuqdog
approved these changes
Nov 22, 2024
njooma
approved these changes
Nov 22, 2024
sguequierre
approved these changes
Nov 22, 2024
Co-authored-by: Sierra Guequierre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the return type of
tabular_data_by_sql/mqlearlier in this PR: #774 but forgot to update the doc string.Also, removed the first example here: https://python.viam.dev/autoapi/viam/app/data_client/index.html#viam.app.data_client.DataClient.tabular_data_by_mql since it is discussed in this thread that bson from bson with bson.dumps() does not work, but bson from pymongo with bson.encode() works does work.