validate pin in [0,64)

viamrobotics · Oct 22, 2024 · 150638f · 150638f
1 parent a2f0da4
commit 150638f
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/micro-rdk/src/esp32/pin.rs b/micro-rdk/src/esp32/pin.rs
@@ -40,6 +40,9 @@ fn install_gpio_isr_service() -> Result<(), BoardError> {
 fn is_valid_gpio_pin(pin: i32) -> Result<(), BoardError> {
     // Do this masking in 64-bit space because it works for both esp32
     // where the mask is 32 bits and esp32s3 where it is 64.
+    if (pin < 0) || (pin >= 64) {
+        return Err(BoardError::InvalidGpioNumber(pin as u32))
+    }
     match (1_u64 << (pin as u64)) & SOC_GPIO_VALID_OUTPUT_GPIO_MASK {
         0 => Err(BoardError::InvalidGpioNumber(pin as u32)),
         _ => Ok(()),