Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic team profiles to "Our Team" section #40

Merged
merged 29 commits into from
Oct 5, 2021
Merged

Add basic team profiles to "Our Team" section #40

merged 29 commits into from
Oct 5, 2021

Conversation

ekuw
Copy link
Collaborator

@ekuw ekuw commented Oct 5, 2021 •
edited by NatalieZelenka
Loading

Description

This PR addresses the basics of issue #18.

  • Names
  • photos
  • contact details
  • social media links

Checklist (contributor)

  • Marked as draft
  • Linked to issue
  • Filled in description
  • Gave this Pull Request a descriptive title

Checklist (maintainer)

  • Built site locally.
  • Changes are as discussed in issue.
  • The PR is to the Our Handbook develop branch
  • New pages are linked in the TOC/navigation?
  • Have we added the contributor to our all-contributors?
  • One sentence per line

@NatalieZelenka
Copy link
Collaborator

Hey @ekuw is this ready for review now?

@NatalieZelenka
Update our-team.md
99bcf89 
Changed the colon fence to the four backticks, just for consistent formatting. I'll add a note to the "style" issue about that.
NatalieZelenka
NatalieZelenka approved these changes Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@NatalieZelenka NatalieZelenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🥇

@ekuw
Copy link
Collaborator Author

ekuw commented Oct 5, 2021

Added more to this PR:

  • current projects (linking to other parts of the book)
  • past projects (linking to other parts of the book)
  • fun thing
  • Past team members
  • Working with us
  • temp files (*~) to gitignore

@ekuw ekuw marked this pull request as ready for review October 5, 2021 11:07
NatalieZelenka
NatalieZelenka reviewed Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@NatalieZelenka NatalieZelenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 😄

ekuw and others added 13 commits October 5, 2021 12:32
@ekuw
Merge branch 'very-good-science:main' into main
af899fd
@allcontributors
docs: update README.md [skip ci]
4547659
@allcontributors
docs: create .all-contributorsrc [skip ci]
9ea8dff
@allcontributors
docs: update README.md [skip ci]
8736a10
@allcontributors
docs: create .all-contributorsrc [skip ci]
52ad053
@allcontributors
docs: update README.md [skip ci]
d23ee2c
@allcontributors
docs: create .all-contributorsrc [skip ci]
34a08e0
@allcontributors
docs: update README.md [skip ci]
fed8985
@allcontributors
docs: create .all-contributorsrc [skip ci]
f40c57a
@jatonline
Merge pull request very-good-science#46 from very-good-science/all-co…
612a2e1 
…ntributors/add-NatalieThurlby

docs: add NatalieThurlby as a contributor for doc, mentoring
@jatonline
Merge branch 'main' into all-contributors/add-ekuw
557340d
@jatonline
Merge pull request very-good-science#47 from very-good-science/all-co…
415f78a 
…ntributors/add-ekuw

docs: add ekuw as a contributor for doc
@jatonline
Merge branch 'main' into all-contributors/add-jatonline
a99e103
@NatalieZelenka NatalieZelenka merged commit e3560c5 into very-good-science:develop Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NatalieZelenka NatalieZelenka NatalieZelenka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekuw @NatalieZelenka @jatonline