Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make access defensive and fix environment variable reference. #156

Closed
wants to merge 5 commits into from

Conversation

emspishak
Copy link
Contributor

@emspishak emspishak commented Nov 14, 2024

process may not exist in all frameworks, this ensures things will continue to work as expected.

process.env[someVar] works in dev mode but not production, so this switches to process.env.NEXT_PUBLIC_....

`process` may not exist in all frameworks, this ensures things will continue to work as expected.
Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
analytics-astro ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:03pm
analytics-next15 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:03pm
analytics-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:03pm
analytics-nuxt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:03pm
analytics-remix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:03pm
analytics-sveltekit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:03pm
analytics-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:03pm

@feugy
Copy link
Member

feugy commented Nov 22, 2024

This shouldn't be needed thanks to #158

@feugy feugy closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants