Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ethereum oracles acceptance criteria updates #1875

Merged
merged 18 commits into from
Aug 8, 2023

Conversation

MuthuVega
Copy link
Contributor

No description provided.

@MuthuVega MuthuVega added this to the ☄️ Cosmic Elevator milestone Aug 3, 2023
@MuthuVega MuthuVega self-assigned this Aug 3, 2023
@MuthuVega MuthuVega changed the title Feat: ethereum oracles acceptance criteria updates chore: ethereum oracles acceptance criteria updates Aug 3, 2023
@wwestgarth
Copy link
Contributor

wwestgarth commented Aug 4, 2023

Can we have an AC for sending in a malicious eth-call chain-event that didn't happen on chain? I think this is important given the security issues we found before. We need to make sure that the on-chain-verification step works and we can only do this with a negative test.

Edit: you can add this in another PR to not block this particular PR.

@MuthuVega
Copy link
Contributor Author

Can we have an AC for sending in a malicious eth-call chain-event that didn't happen on chain? I think this is important given the security issues we found before. We need to make sure that the on-chain-verification step works and we can only do this with a negative test.

Edit: you can add this in another PR to not block this particular PR.

Think the above is covered by this acceptance criteria

6. Will need some tests around consensus, will require setting up a network and having some nodes receive different values for the same oracle data point and testing that the oracle data point is/is not published depending on voting (<a name="0082-ETHD-035" href="#0082-ETHD-035">0082-ETHD-035</a>)

@MuthuVega MuthuVega marked this pull request as ready for review August 4, 2023 11:23
pscott31
pscott31 previously approved these changes Aug 4, 2023
@gordsport gordsport merged commit 16ab9f2 into cosmicelevator Aug 8, 2023
4 checks passed
@gordsport gordsport deleted the chore_eth_oracles_ac_update branch August 8, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants