Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URI and configuration when using proxy #149

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix URI and configuration when using proxy #149

wants to merge 2 commits into from

Conversation

CWftw
Copy link

@CWftw CWftw commented Feb 21, 2024

This fixes 2 bugs

  1. WSS Proxy Setup Broken #147 URI formatting is wrong when using proxy
  2. Configuration, e.g. tlsConfiguration is not used when using proxy

@CWftw CWftw mentioned this pull request Feb 21, 2024
Open
0xTim
0xTim requested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Could you write a test to ensure that the proxy URI is generated correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim requested changes

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CWftw @0xTim