Updating how we create BloomFilter from rdb loads. BloomFilter vec now has capacity of filter we are loading from #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarthikSubbarao
approved these changes
Nov 19, 2024
KarthikSubbarao
force-pushed
the
unstable
branch
3 times, most recently
from
188835b
to
a33e0e3
Compare
…w has capacity of filter we are loading from Signed-off-by: zackcam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were initializing a vector of bloomfilters with Vec::New() which could cause the size to be higher when we pushed an item into the vector during RDB Load and Copy. This is due to the raw alloc vector growth. From testing we saw that it could be four times as large. Which makes sense from this. In order to make this size what we expect we can just set the capacity to the number of filters we know we will be adding