Fix poll_retry and add max_num_poll_retry #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I was looking at the logic that handles retries when a service/node is dead, and I noticed an inconsistency between what the
retry_poll
does in the documentation and how it gets used - it looks likepoll_retry
acts as a maximum number of retries to do rather than a duration to wait between two retries.I've added some minor changes to make the code reflect the documentation and added a new
max_num_poll_retry
config as I know it would be useful for us at least.I am a bit unsure if this is fully a good idea as the user could set a long sleep time which would block probing other nodes in the meantime, potentially for a long time.
Let me know what you think, I hope this is all correct and not a misunderstanding on my part! Thanks.