Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poll_retry and add max_num_poll_retry #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

annesylvie
Copy link

@annesylvie annesylvie commented Jun 28, 2024

Hi!

I was looking at the logic that handles retries when a service/node is dead, and I noticed an inconsistency between what the retry_poll does in the documentation and how it gets used - it looks like poll_retry acts as a maximum number of retries to do rather than a duration to wait between two retries.

I've added some minor changes to make the code reflect the documentation and added a new max_num_poll_retry config as I know it would be useful for us at least.

I am a bit unsure if this is fully a good idea as the user could set a long sleep time which would block probing other nodes in the meantime, potentially for a long time.

Let me know what you think, I hope this is all correct and not a misunderstanding on my part! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant