-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce start/end year for entity #2141
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2141 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 194 194
Lines 11714 11556 -158
Branches 1772 1641 -131
==========================================
- Hits 11714 11556 -158 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad this is finally getting implemented ❤️
This might be something for later, but having subdivision-level start dates would be nice for countries such as Australia or the United States - or a future #1852 implementation. 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🕚
Proposed change
Introduce start/end year of period in which entity holidays are defined (with default values 1901 and 2100).
Type of change
holidays
functionality in general)Checklist
make check
, all checks and tests are green