Migrate Equinoxes and Solstices logic to International
holiday group
#1958
+96
−75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR migrates the existing
Vernal Equinox,
Summer Solstice,
Autumnal Equinox,
andWinter Solstice
implementation logic to the commonInternational
holidays group, hopefully, reducing code redundancy for future holiday additions.(Done in preparation for future #784 implementations i.e. Zurich's historic "Sechseläuten" cases from 1902-1951)
Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally