Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Equinoxes and Solstices logic to International holiday group #1958

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

PPsyrius
Copy link
Collaborator

Proposed change

This PR migrates the existing Vernal Equinox, Summer Solstice, Autumnal Equinox, and Winter Solstice implementation logic to the common International holidays group, hopefully, reducing code redundancy for future holiday additions.

(Done in preparation for future #784 implementations i.e. Zurich's historic "Sechseläuten" cases from 1902-1951)

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

sonarcloud bot commented Aug 28, 2024

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (66bf2df) to head (41f17b6).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1958   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          187       187           
  Lines        11380     11386    +6     
  Branches      1792      1792           
=========================================
+ Hits         11380     11386    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KJhellico
Copy link
Collaborator

This is a useful change. 👍 However, when using these methods for holidays in other countries, you should be careful, as the existing date interpolation code is tested and valid only for the corresponding countries (Chile, Japan, Hong Kong).

@PPsyrius
Copy link
Collaborator Author

PPsyrius commented Aug 28, 2024

@arkid15r @KJhellico Is there a way to convert this PR back to draft status in the meantime? I'd like to work on this a bit more and perhaps expand the supported date ranges down to 1901 before putting this up for review again.

Nevermind, I think I found the button now.

@PPsyrius PPsyrius marked this pull request as draft August 28, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants