Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update sauce connect launcher #89

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,14 @@ jobs:
name: Polymer 2 on the CI agent
runs-on: ubuntu-latest
steps:
- name: Set up Node 12.x
uses: actions/setup-node@v2
- name: Set up Node 16.x
uses: actions/setup-node@v4
with:
node-version: 12.x
node-version: 16.x

- name: Check out the source code
uses: actions/checkout@v2

- name: Install latest npm
# magi-cli 1.0 requires npm 7 or higher
run: "npm install -g npm@8"

- name: Install global npm dependencies
# bower is needed to run 'bower install'
# polymer-cli is needed to run the lint step
Expand All @@ -45,18 +41,14 @@ jobs:
name: Polymer 3 on SauceLabs
runs-on: ubuntu-latest
steps:
- name: Set up Node 12.x
uses: actions/setup-node@v2
- name: Set up Node 16.x
uses: actions/setup-node@v4
with:
node-version: 12.x
node-version: 16.x

- name: Check out the (Polymer 2) source code
uses: actions/checkout@v2

- name: Install latest npm
# magi-cli 1.0 requires npm 7 or higher
run: "npm install -g npm@8"

- name: Install global npm dependencies
# bower and polymer-modulizer are needed to run the Polymer 3 conversion step
run: "npm install --quiet --no-progress --global bower magi-cli polymer-modulizer"
Expand Down
12 changes: 5 additions & 7 deletions package-lock-p3.json
Original file line number Diff line number Diff line change
Expand Up @@ -10039,8 +10039,7 @@
},
"node_modules/sauce-connect-launcher": {
"version": "1.3.2",
"resolved": "https://registry.npmjs.org/sauce-connect-launcher/-/sauce-connect-launcher-1.3.2.tgz",
"integrity": "sha512-wf0coUlidJ7rmeClgVVBh6Kw55/yalZCY/Un5RgjSnTXRAeGqagnTsTYpZaqC4dCtrY4myuYpOAZXCdbO7lHfQ==",
"resolved": "git+ssh://[email protected]/vaadin/sauce-connect-launcher.git#75b065db538ce6ec733e460bd697743df70c632b",
"dev": true,
"hasInstallScript": true,
"optional": true,
Expand Down Expand Up @@ -21588,9 +21587,7 @@
"dev": true
},
"sauce-connect-launcher": {
"version": "1.3.2",
"resolved": "https://registry.npmjs.org/sauce-connect-launcher/-/sauce-connect-launcher-1.3.2.tgz",
"integrity": "sha512-wf0coUlidJ7rmeClgVVBh6Kw55/yalZCY/Un5RgjSnTXRAeGqagnTsTYpZaqC4dCtrY4myuYpOAZXCdbO7lHfQ==",
"version": "git+ssh://[email protected]/vaadin/sauce-connect-launcher.git#75b065db538ce6ec733e460bd697743df70c632b",
"dev": true,
"optional": true,
"requires": {
Expand Down Expand Up @@ -21649,7 +21646,8 @@
"glob": "^7.1.3"
}
}
}
},
"from": "sauce-connect-launcher@vaadin/sauce-connect-launcher#upgrade-sauce-connect-5"
},
"select-hose": {
"version": "2.0.0",
Expand Down Expand Up @@ -23697,7 +23695,7 @@
"cleankill": "^2.0.0",
"lodash": "^4.17.10",
"request": "^2.85.0",
"sauce-connect-launcher": "^1.0.0",
"sauce-connect-launcher": "vaadin/sauce-connect-launcher#upgrade-sauce-connect-5",
"temp": "^0.8.1",
"uuid": "^3.2.1"
},
Expand Down
12 changes: 5 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,10 @@
},
"devDependencies": {
"@vaadin/vaadin-component-dev-dependencies": "^3.2.0"
},
"overrides": {
"wct-sauce": {
"sauce-connect-launcher": "vaadin/sauce-connect-launcher#upgrade-sauce-connect-5"
}
}
}
16 changes: 0 additions & 16 deletions wct.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,6 @@ module.exports = {
]
}
},
// MAGI REMOVE START
istanbul: {
dir: './coverage',
reporters: ['text-summary', 'lcov'],
include: [
'**/vaadin-accordion/src/*.html'
],
exclude: [],
thresholds: {
global: {
statements: 98
}
}
}
// MAGI REMOVE END
},

registerHooks: function(context) {
Expand All @@ -47,7 +32,6 @@ module.exports = {
'iOS Simulator/[email protected]', // should be 9.x, but SauceLabs does not provide that
'macOS 11/safari@latest',
'Windows 10/microsoftedge@latest',
'Windows 10/microsoftedge@18',
'Windows 10/internet explorer@11',
'Windows 10/chrome@latest',
'Windows 10/firefox@latest',
Expand Down
Loading