Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify setup_secrets.sh to use hcp instead of vlt #32

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

aadhyaaamashru
Copy link
Contributor

@aadhyaaamashru aadhyaaamashru commented Sep 23, 2024

Notion ticket link

Modify setup_secrets.sh to use hcp instead of vlt

Implementation description

  • the script should download all secrets from the hashiCorp vault to a .env file.
  • updated it to use hcp instead of vlt

Steps to test

  1. run the script to make sure it correctly creates the .env again and consists of all secrets from HashiCorp

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 5:31am

Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed some uneeded whitespace (linting) and updated the README. LGTM otherwise!

@ChinemeremChigbo ChinemeremChigbo merged commit d37e440 into main Sep 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants