-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
David/file upload #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look into the failing logs. Consider using nektos to run Github Actions locally (and not need to make a commit each time you want to test). This StackOverflow link might be helpful for fixing the failing build issues. If you need any help with anything please let me know and we can do some pair programming:
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed first few files. Will review the remainder later.
…vid/file-upload
Co-authored-by: Chinemerem <[email protected]>
20f94c7
to
cdf34c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work David! Please address my comments and then feel free to merge. Just a heads up that the actual upload UI in the sistema app won't need the listing functionality since the links to the files will be stored in the database, but thanks for the implementation regardless.
Notion ticket link
Implement File Uploading
Implementation description
Steps to test
What should reviewers focus on?
Checklist