Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

David/file upload #13

Merged
merged 45 commits into from
Oct 6, 2024
Merged

David/file upload #13

merged 45 commits into from
Oct 6, 2024

Conversation

ludavidca
Copy link
Collaborator

@ludavidca ludavidca commented Jun 26, 2024

Notion ticket link

Implement File Uploading

Implementation description

  • Created simple UI for file uploading
  • Implemented NEXTJS routes for uploading to google drives
  • Created Google Project to facilitate Create operations

Steps to test

  1. Pull new env variables from vault
  2. Navigate to localhost:3000/page and upload a file
  3. Check [email protected] to ensure that the file is in the lesson plan folder

What should reviewers focus on?

  • Cleanliness of code
  • Ability for team members to understand and build on top of existing code

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look into the failing logs. Consider using nektos to run Github Actions locally (and not need to make a commit each time you want to test). This StackOverflow link might be helpful for fixing the failing build issues. If you need any help with anything please let me know and we can do some pair programming:

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 5:05pm

Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed first few files. Will review the remainder later.

.env.sample Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
.env.sample Outdated Show resolved Hide resolved
.env.sample Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work David! Please address my comments and then feel free to merge. Just a heads up that the actual upload UI in the sistema app won't need the listing functionality since the links to the files will be stored in the database, but thanks for the implementation regardless.

app/api/deleteFile/route.ts Outdated Show resolved Hide resolved
app/api/searchDrive/route.ts Outdated Show resolved Hide resolved
app/api/uploadFile/route.ts Outdated Show resolved Hide resolved
@ludavidca ludavidca merged commit b88f409 into main Oct 6, 2024
3 checks passed
@ludavidca ludavidca deleted the david/file-upload branch October 6, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants