Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Tasks Modal Component #92

Merged
merged 9 commits into from
Jul 8, 2024
Merged

Create Tasks Modal Component #92

merged 9 commits into from
Jul 8, 2024

Conversation

cindyhjli
Copy link
Contributor

@cindyhjli cindyhjli commented Jul 4, 2024

Notion ticket link

Create Tasks Modal Component

Implementation description

  • created task model component

Steps to test

  1. click edit task button

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@cindyhjli cindyhjli changed the title Tasks Modal Component Create Tasks Modal Component Jul 4, 2024
@cindyhjli cindyhjli requested a review from ya5er July 4, 2024 01:18
Copy link
Contributor

@ya5er ya5er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing - the modals are all titled "Edit Chore" for required, optional, custom tasks, and chores as well. Will approve but can this be changed in the next ticket?

Screenshot 2024-07-08 at 7 36 14 PM

@ya5er ya5er merged commit 8796d6c into dev Jul 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants