Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop frontend for creating announcements #83

Merged

Conversation

KathleenX7
Copy link
Contributor

Notion ticket link

Develop frontend for creating announcements

Implementation description

  • Add room button creates a new tab with greyed out title "New Announcement"
  • Clicking on the new tab brings up a different right panel. There is a + button where you can add and remove Rooms
  • Adding rooms will change the title of the tab from "New Announcement" to a list of rooms
  • Pressing post with rooms defined and text in the text box will remove the new announcement

Steps to test

  1. Click add room button
  2. Click on New Announcements tab
  3. Try adding and removing rooms (tab title will also change)
  4. Add text in "Type an announcement..." and press post. This should delete the new tab.

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@KathleenX7 KathleenX7 self-assigned this Jun 6, 2024
@ya5er ya5er merged commit 03ed538 into dev Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants