Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of List-View UI for Schedule Page #107

Merged
merged 11 commits into from
Nov 2, 2024
Merged

Conversation

jyan36
Copy link
Collaborator

@jyan36 jyan36 commented Sep 28, 2024

Notion ticket link

Schedule Page - List-View UI

Implementation description

  • Utilized mock data to create a list schedule UI for both weekly task and daily tasks, similar to the tasks list.
  • Added ScheduleTable to provide a common table for the two schedules (weekly and daily) taking in the mock data and generating a table.
  • Utilized the ScheduleTable and created a tabs list for the daily tasks in order to be able to switch between days. Currently we have a map of days in the enum to their data mock, this would need to be changed to get the actual date's data, potentially in a different way.

Steps to test

  1. Go to schedule page, scroll down past the cards, and you should see two tables. For example, this is the table for Daily Tasks:
    image
  2. If you click between tabs the data should change for some days (although some of the days are the same).

What should reviewers focus on?

  • Make sure all indenting styling is okay on their end ("Weekly Tasks" and "Daily Tasks" left aligned with table, tabs on the Daily Tasks are aligned on top of the table, etc).

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@jeessh jeessh merged commit c642cb0 into dev Nov 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants