tr: generate an error if the input is a directory #6855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tested by tests/misc/read-errors
|
GNU testsuite comparison: |
cakebaker
reviewed
Nov 20, 2024
Comment on lines
+17
to
+19
| fn test_invalid_input() { | ||
| new_ucmd!().args(&["1", "1", "<", "."]).fails().code_is(1); | ||
| } |
There was a problem hiding this comment.
This test passes even without applying the other changes. So I would also check for the error message.
cakebaker
reviewed
Nov 20, 2024
| while let Ok(length) = input.read_until(b'\n', &mut buf) { | ||
| loop { | ||
| let length = match input.read_until(b'\n', &mut buf) { | ||
| Ok(0) => break, // EOF reached |
There was a problem hiding this comment.
This line makes the break on line 600 unreachable. So I would either remove this line (and probably you can get rid of the match, too) or remove the if and the if-case on lines 599 - 601.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested by tests/misc/read-errors