comm: generate an error if the input is a directory #6853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
tested by tests/misc/read-errors
|
GNU testsuite comparison: |
cakebaker
reviewed
Nov 17, 2024
Comment on lines
+133
to
+137
| let path = Path::new(name); | ||
| if metadata(path)?.is_dir() { | ||
| return Err(io::Error::new(io::ErrorKind::Other, "Is a directory")); | ||
| } | ||
| let f = File::open(path)?; |
There was a problem hiding this comment.
Is the path variable necessary? Unless I'm missing something I think you can pass name directly to metadata and File::open.
cakebaker
reviewed
Nov 17, 2024
Comment on lines
+306
to
+307
| at.mkdir("dir"); | ||
|
|
There was a problem hiding this comment.
A detail:
Suggested change
| at.mkdir("dir"); | |
| at.mkdir("dir"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested by tests/misc/read-errors