Convert control statement bodies to blocks #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently single line control statements are not enclosed in blocks. This is dangerous because people tend to follow the indentation, not the actual control structure, so the following:
can be modified by someone who's not careful to be
which won't do what they think it's doing. It's much safer to just always wrap things as blocks even though it costs an extra line of vertical space.
The automatic refactoring was done using Eclipse cleanup followed by manual verification.