[MOBILE-4785] Add support for Airship Notification Service Extension #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ulrico972
requested review from
jyaganeh,
ilitvinenko,
crow,
Apekka and
oristanovic
rlepinski
reviewed
Nov 26, 2024
|
|
||
| import AirshipServiceExtension | ||
|
|
||
| class AirshipNotificationService: UANotificationServiceExtension { |
There was a problem hiding this comment.
Could you make it possible for them to give us a file path to use instead of ours?
There was a problem hiding this comment.
Yeah I can do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds a basic Airship Notification Service Extension by copying files and adding the appropriate settings.
Why are these changes necessary?
To support Notification Service Extension in an Expo way.
How did you verify these changes?
Adding the plugin to an Expo app and verifying Notification Service Extension is well added with all it needs to work.
Build and run, and check that we can receive pushes with image.
Verification Screenshots:
Anything else a reviewer should know?