Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cachesubnetgroup and fix name in parametergroup #40

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

stevendborrelli
Copy link
Member

Description of your changes

  • Adds a common converter for Elasticache parameter group
  • Fixes missing name parameter from ParameterGroup

How has this code been tested

  • run locally against a CacheSubnetGroup and ParameterGroup

Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevendborrelli I left a comment.

converters/provider-aws/elasticache/cachesubnetgroup.go Outdated Show resolved Hide resolved
Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevendborrelli LGTM!

Signed-off-by: Steven Borrelli <[email protected]>
@stevendborrelli
Copy link
Member Author

I've updated dependencies to crossplane/upjet 1.0.0 and the newer providers.

@sergenyalcin sergenyalcin merged commit 39945e5 into upbound:main Dec 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants