Move and make utilizable common converters #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergenyalcin
force-pushed
the
common-converters
branch
4 times, most recently
from
3810e95
to
8e4d34c
Compare
Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
force-pushed
the
common-converters
branch
from
8e4d34c
to
c5b4981
Compare
ulucinar
reviewed
Aug 3, 2023
converters/common/common.go
Outdated
| return errors.Wrap(convertTagsInPatchset(sourcePatchSets, tagsPatchSetName), "failed to convert patch sets") | ||
| } | ||
|
|
||
| func ConvertPatchesMap(sourceTemplate v1.ComposedTemplate, conversionMap map[string]string) []v1.Patch { |
There was a problem hiding this comment.
I think, at a future iteration, we can move this migration source field path to the migration target field path conversion functionality to the default converter implementation (migration.CopyInto) in the core framework.
There was a problem hiding this comment.
I agree. Let's handle this in a different iteration. It might be nice to merge this as soon as possible for other stakeholders to use.
haarchri
reviewed
Aug 4, 2023
Signed-off-by: Sergen Yalçın <[email protected]>
Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
force-pushed
the
common-converters
branch
from
9219a53
to
46bc6b3
Compare
ulucinar
reviewed
Aug 11, 2023
Signed-off-by: Sergen Yalçın <[email protected]>
ulucinar
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Depends on: crossplane/upjet#251
This PR:
Converters previously written in private repos are moved here as reusable components.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested