Remove explicit transitive dependencies #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It is to avoid in higher level abstaction like platform-ref-azure ``` k get configurations NAME INSTALLED HEALTHY PACKAGE AGE platform-ref-azure True True platform-ref-azure-v0.5.0-rc.0.126.g48f317c.dirty.gz 10m upbound-configuration-app True True xpkg.upbound.io/upbound/configuration-app:v0.4.0 10m upbound-configuration-azure-aks True True xpkg.upbound.io/upbound/configuration-azure-aks:v0.6.0 10m upbound-configuration-azure-database True Unknown xpkg.upbound.io/upbound/configuration-azure-database:v0.11.1 10m upbound-configuration-azure-network True True xpkg.upbound.io/upbound/configuration-azure-network:v0.7.0 10m upbound-configuration-gitops-flux True True xpkg.upbound.io/upbound/configuration-gitops-flux:v0.4.0 9m56s upbound-configuration-observability-oss True True xpkg.upbound.io/upbound/configuration-observability-oss:v0.4.0 9m59s ``` ``` k describe configurationrevisions.pkg.crossplane.io upbound-configuration-azure-database-9875304b4465 ... Warning ResolveDependencies 45s (x11 over 9m45s) packages/configurationrevision.pkg.crossplane.io cannot resolve package dependencies: incompatible dependencies: [xpkg.upbound.io/upbound/configuration-azure-network xpkg.upbound.io/crossplane-contrib/function-patch-and-transform] ``` Signed-off-by: Yury Tsarev <[email protected]>
|
actually we need them here, at least the function. |
|
solved in higher level abstraction dependency bump upbound/platform-ref-azure#90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested